Anyone see any flaws in my cloaking code? I can't seem to get anything by. It started from Nicky Cakes code then I tried to add all the other reviewers.
My php facebook cloaking accurate?
- Thread starter Despoil
- Start date
- Status
Biggest flaw I see is, that you repeated
A number of times when you could have simply
basically you want to goto the normal url when people are not coming from the review/developer section of facebook, well strpos can return 0 if the match is found at the beginning of the string, meaning a positive that appears to be a false. And since == can match 0 as a false, you want to use === to match a boolean false. In the code above its stating if this, that and that is false goto the normal url, otherwise goto the cloaked url.
Apparently nicky is not a coder if he conditioned strpos in that way on the original code.
Code:
Header( "HTTP/1.1 301 Moved Permanently" );
Header( "Location: " . "affili site" ); (and it's variants)A number of times when you could have simply
Code:
<?php
$cloaked_url = "http://www.google.com"; // devs go here
$normal_url = "http://www.yahoo.com"; // everyone else goes here
$tracking_ref = $_SERVER['HTTP_REFERER'];
if((strpos($tracking_ref,"dev.facebook") === false) && (strpos($tracking_ref,"devrs001.facebook.com") === false) && (strpos($tracking_ref,"/intern/ads/review.php") === false))
{
$target = $normal_url;
} else {
$target = $cloaked_url;
}
Header( "HTTP/1.1 301 Moved Permanently" );
Header( "Location: " . $target);
?>basically you want to goto the normal url when people are not coming from the review/developer section of facebook, well strpos can return 0 if the match is found at the beginning of the string, meaning a positive that appears to be a false. And since == can match 0 as a false, you want to use === to match a boolean false. In the code above its stating if this, that and that is false goto the normal url, otherwise goto the cloaked url.
Apparently nicky is not a coder if he conditioned strpos in that way on the original code.
Wow great reply thanks big time. Yeah looks like I was way off haha. Thanks for the huge help again!
- Status